Dockerfile set up#37
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Kafka configuration and container orchestration while establishing a Docker-based development environment.
- Refactors Kafka broker configuration to use an environment variable (KAFKA_BROKER_URL) instead of hardcoding "localhost:9092"
- Updates integration tests, order simulator, and settings to align with dynamic Kafka configuration
- Introduces a Dockerfile, an entrypoint script, and updates the GitHub workflows to better accommodate the new Docker and Kafka settings
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shipments/tests/test_integration_kafka.py | Uses settings.KAFKA_BROKER_URL for Producer configuration |
| order_simulator.py | Refactors event attributes and uses environment fallback for Kafka |
| logistics_core/settings.py | Reads KAFKA_BROKER_URL from environment variables |
| entrypoint.sh | Adds migration and run commands for Docker container startup |
| docker-compose.yml | Updates Kafka listener and adds service dependencies |
| Dockerfile | Creates a container build for the Django application |
| .github/workflows/tests.yml | Revises dependency installation and waits for Kafka readiness |
| .env.example | Provides sample environment variable settings for local development |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…dockerize # Conflicts: # .github/workflows/tests.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.